[U-Boot] [PATCH v2 7/9] arc: add AXS101 board support
Wolfgang Denk
wd at denx.de
Fri Jan 31 00:13:36 CET 2014
Dear Alexey,
In message <1391088984.3518.35.camel at abrodkin-8560l.internal.synopsys.com> you wrote:
>
> > > +#define CONFIG_HOSTNAME axs101
> > > +#define CONFIG_ETHADDR 4a:56:49:22:3e:43
> > > +#define CONFIG_IPADDR 10.121.8.200
> > > +#define CONFIG_SERVERIP 10.121.8.31
> > > +#define CONFIG_GATEWAYIP 10.121.8.1
> > > +#define CONFIG_NETMASK 255.255.255.0
> >
> > We do not allow any such fixed network parameters in the board config
> > headers.
>
> I see tons of boards do have these parameters set in
> "include/configs/xxx".
Pre-historic sins. You happen to have a bit of tough luck when
chosing your examples to copy from.
> I may indeed remove them in from my board but why keep it in others?
> So people won't be confused any longer.
Cleanup patches are welcome.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There are two ways of constructing a software design. One way is to
make it so simple that there are obviously no deficiencies and the
other is to make it so complicated that there are no obvious defi-
ciencies. - Charles Anthony Richard Hoare
More information about the U-Boot
mailing list