[U-Boot] [PATCH v2 7/9] arc: add AXS101 board support

Alexey Brodkin abrodkin at synopsys.com
Fri Jan 31 15:49:06 CET 2014


Hello Wolfgang,

On Fri, 2014-01-31 at 00:13 +0100, Wolfgang Denk wrote:
> Dear Alexey,
> 
> In message <1391088984.3518.35.camel at abrodkin-8560l.internal.synopsys.com> you wrote:
> > 
> > > > +#define	CONFIG_HOSTNAME			axs101
> > > > +#define	CONFIG_ETHADDR			4a:56:49:22:3e:43
> > > > +#define	CONFIG_IPADDR			10.121.8.200
> > > > +#define	CONFIG_SERVERIP			10.121.8.31
> > > > +#define	CONFIG_GATEWAYIP		10.121.8.1
> > > > +#define	CONFIG_NETMASK			255.255.255.0
> > > 
> > > We do not allow any such fixed network parameters in the board config
> > > headers.
> > 
> > I see tons of boards do have these parameters set in
> > "include/configs/xxx".
> 
> Pre-historic sins.  You happen to have a bit of tough luck when
> chosing your examples to copy from.
> 
> > I may indeed remove them in from my board but why keep it in others?
> > So people won't be confused any longer.
> 
> Cleanup patches are welcome.

Understood.
I removed all my network parameters and will take a duty of cleaning up
other configs.

The question then if CONFIG_HOSTNAME could be left?
I see people rely on host name for selection (through name) of boot
files (uImage, fdt etc.)

For example "include/configs/amcc-common.h",
"include/configs/manroland/common.h" and others.

Regards,
Alexey



More information about the U-Boot mailing list