[U-Boot] [PATCH V2] usb: ci_udc: Allocate the qTD list directly

Marek Vasut marex at denx.de
Tue Jul 1 12:17:41 CEST 2014


On Tuesday, July 01, 2014 at 08:51:45 AM, Jörg Krause wrote:
> On 07/01/2014 02:04 AM, Marek Vasut wrote:
> > Instead of weird allocation of ci_drv->items_mem and then even weirder
> > distribution of offsets in this memory area into ci_drv->items array,
> > just allocate ci_drv->items as a big slab of aligned memory (replaces
> > ci_drv->items_mem) and let ci_get_qtd() do the distribution of offsets
> > in this memory area.
> > 
> > Signed-off-by: Marek Vasut <marex at denx.de>
> > Cc: Jörg Krause <jkrause at posteo.de>
> > Cc: Stephen Warren <swarren at wwwdotorg.org>
> > ---
> > 
> >   drivers/usb/gadget/ci_udc.c | 19 ++++++-------------
> >   drivers/usb/gadget/ci_udc.h |  3 +--
> >   2 files changed, 7 insertions(+), 15 deletions(-)
> > 
> > V2: Rebase on top of u-boot-usb/master instead of the research branch

[...]

> I made a test on u-boot-arm/master before (Test#1) and after applying
> this patch (Test#2).

Can we please sync on the same codebase (u-boot-usb/master) ?

> After a reset I run this script:
> test_usb=setenv i 64; while test ${i} -gt 0; do echo ${i}; tftp
> ${rootfs_file}; setexpr i ${i} - 1; done; setenv i;
> 
> Both tests (Test#1 and Test#2) runs fine with the script. But if I do
> run tftp ${rootfs_file} manually from the console, I get the known error
> starting the fourth run for both Test#1 and Test#2.

Can you edit arch/arm/cpu/arm926ejs/cache.c and change the debug() to printf() , 
then re-test please ? I suspect this might trap something still. Ah, and please 
test on u-boot-usb/master with this patch.

Best regards,
Marek Vasut


More information about the U-Boot mailing list