[U-Boot] [PATCH] USB: gadget: atmel: zero out allocated requests

[Bo Shen]

Hi Stephen Warren,

On 07/02/2014 06:59 AM, Stephen Warren wrote:
> From: Stephen Warren <swarren at nvidia.com>
>
> A UDC's alloc_request method should zero out the newly allocated request.
> Ensure the Atmel driver does so. This issue was found by code inspection,
> following the investigation of an intermittent issue with ci_udc, which
> was tracked down to failing to zero out allocated requests following some
> of my changes. All other UDC drivers already zero out requests in one
> way or another.
>
> Signed-off-by: Stephen Warren <swarren at nvidia.com>
> ---
>   drivers/usb/gadget/atmel_usba_udc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Thanks.
Acked-by: Bo Shen <voice.shen at atmel.com>

> diff --git a/drivers/usb/gadget/atmel_usba_udc.c b/drivers/usb/gadget/atmel_usba_udc.c
> index c99208d10200..2c709738a3cb 100644
> --- a/drivers/usb/gadget/atmel_usba_udc.c
> +++ b/drivers/usb/gadget/atmel_usba_udc.c
> @@ -314,7 +314,7 @@ usba_ep_alloc_request(struct usb_ep *_ep, gfp_t gfp_flags)
>
>   	DBG(DBG_GADGET, "ep_alloc_request: %p, 0x%x\n", _ep, gfp_flags);
>
> -	req = malloc(sizeof(struct usba_request));
> +	req = calloc(1, sizeof(struct usba_request));
>   	if (!req)
>   		return NULL;
>
>

Best Regards,
Bo Shen