[U-Boot] [PATCH v3 13/13] fit: make sha256 support optional

[Tom Rini]

On Thu, Jul 03, 2014 at 09:14:01AM -0700, Simon Glass wrote:
> Hi,
> 
> On 3 July 2014 00:03, Heiko Schocher <hs at denx.de> wrote:
> >
> > Hello Dirk,
> >
> > Am 03.07.2014 08:27, schrieb dirk.eibach at gdsys.cc:
> >
> >> From: Dirk Eibach<dirk.eibach at gdsys.cc>
> >>
> >> sha256 has some beefy memory footprint.
> >> Make it optional for constrained systems.
> >>
> >>
> >> Signed-off-by: Dirk Eibach<dirk.eibach at gdsys.cc>
> >> ---
> >>
> >> Changes in v3: None
> >> Changes in v2:
> >> - make sha256 support optional
> >>
> >>   include/configs/dlvision-10g.h | 1 +
> >>   include/configs/io.h           | 1 +
> >>   include/configs/iocon.h        | 1 +
> >>   include/configs/neo.h          | 1 +
> >>   include/image.h                | 5 +++++
> >>   5 files changed, 9 insertions(+)
> >
> >
> > Sorry, some nitpick. As you introduce here the new define "CONFIG_FIT_DISABLE_SHA256",
> > can you please add a short description in the README, thanks!
> 
> I wonder if it would be better to make the option off by default? You
> could perhaps use the existing CONFIG_SHA256 option, and check in
> image.h to enable/disable support.
> 
> Heiko what do you think?

I think I like this unless there's a problem...

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140703/6ae56289/attachment.pgp>