[U-Boot] [PATCH] ARM:asm:io.h use static inline

Albert ARIBAUD albert.u.boot at aribaud.net
Sat Jul 5 11:13:59 CEST 2014


Hi Jeroen,

On Sun, 22 Jun 2014 23:10:39 +0200, Jeroen Hofstee
<jeroen at myspectrum.nl> wrote:

> When compiling u-boot with W=1 the extern inline void for
> read* is likely causing the most noise. gcc / clang will
> warn there is never a actual declaration for these functions.
> Instead of declaring these extern make them static inline so
> it is actually declared.
> 
> cc: Albert ARIBAUD <albert.u.boot at aribaud.net>
> Signed-off-by: Jeroen Hofstee <jeroen at myspectrum.nl>
> ---

Ok, so the obvious question: what makes you decide to switch to 'static
inline' rather than provide the extern versions that 'extern static'
calls for?

(see e.g. http://elinux.org/Extern_Vs_Static_Inline for an example
discussion on 'static inline' vs 'extern inline'. Note: this link is not
intended as an expression of my stance on the issue, as I don't have
any.)

Amicalement,
-- 
Albert.


More information about the U-Boot mailing list