[U-Boot] [PATCH v6] arm: ep9315: Return back Cirrus Logic EDB9315A board support

Masahiro Yamada yamada.m at jp.panasonic.com
Mon Jul 7 12:57:55 CEST 2014


Hi. Sergey, Arbert.


On Sat, 5 Jul 2014 00:22:05 +0200
Albert ARIBAUD <albert.u.boot at aribaud.net> wrote:

> Hi Sergey,
> 
> On Wed, 25 Jun 2014 23:44:29 +0400, Sergey Kostanbev
> <sergey.kostanbaev at gmail.com> wrote:
> 
> > This patch returns back support for old ep93xx processors family
> > 
> > Signed-off-by: Sergey Kostanbaev <sergey.kostanbaev at gmail.com>
> > Cc: albert.u.boot at aribaud.net
> > ---
[snip]
> 
> Applied to u-boot-arm/master, thanks!
> 
> Amicalement,
> -- 
> Albert.




I have two questions:

[1] Is this board really working?

This patch added a linker script
board/cirrus/edb93xx/u-boot.lds

But '.vectors' section is missing from it.

In my understanding, commit 41623c91b0 expects '.vectors'
section handling for all ARM linker scripts.


[2] Why was board/cirrus/edb93xx/u-boot.lds added
instead of re-using (or modifying) arch/arm/cpu/arm920t/ep93xx/u-boot.lds ?


'edb9315a' is the only one board with 'ep93xx' SoC.

It means, if you add 'board/cirrus/edb93xx/u-boot.lds',
'arch/arm/cpu/arm920t/ep93xx/u-boot.lds' is never used.

Please delete either of them.




Best Regards
Masahiro Yamada



More information about the U-Boot mailing list