[U-Boot] [PATCH 1/3] ARM: omap: Fix GPMC init for OMAP3 platforms

[Stefan Roese]

Hi Pekon,

On 09.07.2014 20:22, Gupta, Pekon wrote:
>> Commit a0a37183 (ARM: omap: merge GPMC initialization code for all
>> platform) broke NAND on OMAP3 based platforms. I noticed this while
>> testing the latest 2014.07-rc version on the TAO3530 board. NAND
>> detection did not work with this error message:
>>
>> NAND:  nand: error: Unable to find NAND settings in GPMC Configuration - quitting
>>
>> As OMAP3 configs don't set CONFIG_NAND but CONFIG_NAND_CMD. the GPMC
>> was not initialized for NAND at all. This patch now fixes this issue.
>>
> Sorry couldn't understand this, why have users enabled CONFIG_NAND_CMD,
> if CONFIG_NAND itself is not enabled ?

CONFIG_NAND doesn't seem to be a mandatory define if NAND is used. Many 
OMAP3 based boards don't enable this define but still use NAND. The 
"old" mem.c also did only check for CONFIG_CMD_NAND to configure the 
GPMC accordingly. Thats why I chose to change mem-common.c to accept 
this kind of configuration instead of changing all those config headers 
to enable CONFIG_NAND.

> Otherwise, if TAO3530 board uses the on-die NAND, then it should enable
> NAND in its board profile via boards.cfg

Sorry, I don't understand what this has to do with on-die NAND. This 
patch is a clear fix to restore the original behavior with the "old" mem.c.

Thanks,
Stefan