[U-Boot] [PATCH] Ethernet: let user know if there is no valid ethernet address

[Wolfgang Denk]

Dear Pavel,

In message <20140711163247.GA14873 at amd.pavel.ucw.cz> you wrote:
>
> > Sorry, but this is not really helpful.  "Not set" and "not valid" are
> > different things.  "Not valid" might be confusing when none is set at
> > all.
> 
> Well, it is what the code checks for.
> 
> > Also, if I understand correctly, we will now have _two_ error messages
> > ("ethernet address not valid" followed by "could not set ethernet
> > address")?  That's not so nice either.
> 
> Ok, would it be acceptable to change 'count not set' message to 'could
> not set or invalid address' and print the address as well?

Print the address - if it is not set?  I think we should provide useful
error messages.  Either the address has not been set, then we should
say so, or it is invalid, then we should say that.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
panic: kernel trap (ignored)