[U-Boot] [PATCH] common: env_common: make env_get_char_spec __weak

Wolfgang Denk wd at denx.de
Fri Jul 11 21:14:38 CEST 2014


Dear Jeroen Hofstee,

In message <53C01BD7.8030608 at myspectrum.nl> you wrote:
> 
> >> -static uchar __env_get_char_spec(int index)
> >> +__weak uchar env_get_char_spec(int index)
> > __weak static ... ?
> 
> tempting huh, but it is the patch format with tricks
> you in thinking that. The weak is actually added to
> the function without the leading underscores, a
> couple of lines below (which wasn't static and
> shouldn't become so).

Argh.  You are right.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Sometimes, too long is too long.                          - Joe Crowe


More information about the U-Boot mailing list