[U-Boot] [PATCH v2 03/29] stdio: Remove redundant code around stdio_register() calls

Simon Glass sjg at chromium.org
Sun Jul 13 18:13:33 CEST 2014


Hi Marek,

On 10 July 2014 17:23, Marek Vasut <marex at denx.de> wrote:
>
> On Wednesday, July 09, 2014 at 05:37:53 AM, Simon Glass wrote:
> > There is no point in setting a structure's memory to NULL when it has
> > already been zeroed with memset().
> >
> > Also, there is no need to create a stub function for stdio to call - if the
> > function is NULL it will not be called.
> >
> > This is a clean-up, with no change in functionality.
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > Acked-by: Marek Vasut <marex at denx.de>
> > ---
>
> Acked-by: Marek Vasut <marex at denx.de>
>
> Some of those implementations really make my head spin ... *sigh* . Thank you
> for cleaning this up a bit !

I think it will be good to get this tidied up. I'm doing things
incrementally as I think that is the best approach given the
complexity and interaction with driver model work, etc.

Regards,
Simon


More information about the U-Boot mailing list