[U-Boot] [PATCH] lib/time.c cleanups

Pavel Machek pavel at denx.de
Mon Jul 14 13:58:08 CEST 2014


On Sun 2014-07-13 15:26:18, Marek Vasut wrote:
> On Sunday, July 13, 2014 at 01:14:27 PM, Pavel Machek wrote:
> [...]
> > @@ -51,9 +52,10 @@ unsigned long long __weak notrace get_ticks(void)
> >  	return ((unsigned long long)gd->timebase_h << 32) | gd->timebase_l;
> >  }
> > 
> > -static unsigned long long notrace tick_to_time(uint64_t tick)
> > +/* Returns time in milliseconds */
> 
> Please see http://www.denx.de/wiki/U-Boot/CodingStyle at the bottom in case you 
> want to add documentation annotations.
> [...]

Well, I'd like to document return values, but don't think full
kerneldoc is not neccessary. That should not be against CodingStyle
AFAICT.

Thanks,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


More information about the U-Boot mailing list