[U-Boot] [PATCH v3 3/6] pwm, imx6: add support for pwm modul on imx6

[Wolfgang Denk]

Dear Stefano & Heiko,

In message <53C64270.7050507 at denx.de> you wrote:
> 
> > diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c
> > new file mode 100644
> > index 0000000..c70e150
> > --- /dev/null
> > +++ b/drivers/pwm/pwm-imx.c
> > @@ -0,0 +1,109 @@
> > +/*
> > + * (C) Copyright 2014
> > + * Heiko Schocher, DENX Software Engineering, hs at denx.de.
> > + *
> > + * Basic support for the pwm modul on imx6.
> > + *
> > + * Based on linux:drivers/pwm/pwm-imx.c
> > + * from
> > + * Sascha Hauer <s.hauer at pengutronix.de>
> > + *
> > + * SPDX-License-Identifier:	GPL-2.0+

Is this really GPL-2.0+ ?  The Linux driver is definitely GPL-2.0
only!

> Nice ! Should we also add in the commit message that the code is
> directly taken from kernel driver ?

Not should - must!

Exact reference including commit ID is mandatory!

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If you're out of tree, you don't exist.
     - David Woodhouse in <1304620350.2398.29.camel at i7.infradead.org>