[U-Boot] [PATCH v1 7/7] board/ti/dra7xx: add support for parallel NAND

Gupta, Pekon pekon at ti.com
Thu Jul 17 12:59:58 CEST 2014


>From: Tom Rini [mailto:tom.rini at gmail.com] On Behalf Of Rini, Tom
>>On Sat, Jul 05, 2014 at 12:35:17AM +0530, Pekon Gupta wrote:
>
>> This patch adds support for x16 NAND device (MT29F2G16AAD) connected to GPMC
>> chip-select present on DRA7xx EVM.
>> On this board, GPMC_WPN and NAND_BOOTn are controlled by DIP switch,
>> So following board settings are required for NAND device detection:
>>   SW5.9 (GPMC_WPN) = LOW
>>   SW5.1 (NAND_BOOTn) = HIGH
>
>First, again, I don't like moving towards NAND being the default assumed
>present storage and making QSPI harder to use.  Second, I forgot about
>this earlier but for the record and per later emails, we should just use
>CONFIG_CMD_NAND rather than CONFIG_NAND.
>
All your feedbacks taken, except below one which is bit trivial ..

Converting CONFIG_NAND to CONFIG_CMD_NAND need review because:
(1) CONFIG_NAND has spread to so many files, and is also part of 
    include/configs/ti_armv7_common.h
    arch/arm/cpu/armv7/omap-common/mem.c
And many more places..

(2) CONFIG_CMD_NAND is not synonymous with other CONFIG_xx which
 used for enabling complete subsystem like CONFIG_NOR, CONFIG_MMC.

So, for now I'll continue using CONFIG_NAND, and may be later if
CONFIG_NAND needs to be deprecated, then it can come as separate
patch series. Hope that is fine?


with regards, pekon


More information about the U-Boot mailing list