[U-Boot] socfpga: initialize MMC

Chin Liang See clsee at altera.com
Thu Jul 17 13:00:52 CEST 2014


Hi Wolfgang,

On Wed, 2014-07-16 at 15:13 +0200, ZY - wd wrote:
> Dear Pavel,
> 
> In message <20140716125238.CF3833804B5 at gemini.denx.de> I wrote:
> > 
> > > +	add_dwmci(host, host->bus_hz, host->bus_hz);
> > 
> > Is there a free(host) anywhere?


Actually the host will be referred throughout the code execution when
SDMMC access is required. Hence, we can only call the free when exit
which deems not needed then.

Thanks
Chin Liang

> 
> I think there is none, which raises the question why you use malloc()
> in the first place.  Just use a struct on the stack.
> 
> Also, please make sure to check the return code of add_dwmci() for
> errors, and handle these as needed.
> 
> Best regards,
> 
> Wolfgang Denk
> 




More information about the U-Boot mailing list