[U-Boot] [PATCH] whitespace cleanups

Jeroen Hofstee jeroen at myspectrum.nl
Sun Jul 20 00:23:04 CEST 2014


Hello Pavel,

On 20-07-14 00:13, Pavel Machek wrote:
> On Sun 2014-07-20 00:02:37, Jeroen Hofstee wrote:
>> Hello Pavel,
>>
>> On 19-07-14 23:50, Pavel Machek wrote:
>>> Whitespace cleanups.
>>>
>>> Signed-off-by: Pavel Machek <pavel at denx.de>
>>>
>>> diff --git a/disk/part.c b/disk/part.c
>>> index baceb19..ecc5e7e 100644
>>> --- a/disk/part.c
>>> +++ b/disk/part.c
>>> @@ -333,7 +333,7 @@ static void print_part_header (const char *type, block_dev_desc_t * dev_desc)
>>>   #endif /* any CONFIG_..._PARTITION */
>>> -void print_part (block_dev_desc_t * dev_desc)
>>> +void print_part(block_dev_desc_t * dev_desc)
>>>   {
>>>   		switch (dev_desc->part_type) {
>>> @@ -381,8 +381,8 @@ void print_part (block_dev_desc_t * dev_desc)
>> checkpatch says: ;)
>>
>> ERROR: "foo * bar" should be "foo *bar"
>> #26: FILE: disk/part.c:336:
>> +void print_part(block_dev_desc_t * dev_desc)
> Yeah, I did not fix _all_ broken whitespace, just some. Note that I'm
> not adding the error.
> 								

This is only about a line you touch. And patch submissions should be
checked by checkpatch or at least mention why you don't comply.

Regards,
Jeroen


More information about the U-Boot mailing list