[U-Boot] Bug u-boot-tools: /usr/include/image.h gets included instead of <WC>/include/image.h

[Jeroen Hofstee]

Hello Chris,

On 20-07-14 12:30, disposable at gmx.net wrote:
> Hi list,
>
> the package lensfun (http://lensfun.sourceforge.net/) ships an image.h which gets installed in /usr/include/image.h.
> When I build u-boot from the latest commit 524123a, it bails out with the following error:
>
>> git clone git://git.denx.de/u-boot.git
>> cd u-boot
>> make coreboot-x86_config
>> make
> 1 CHK include/config/uboot.release
> 2 CHK include/generated/version_autogenerated.h
> 3 CHK include/generated/timestamp_autogenerated.h
> 4 UPD include/generated/timestamp_autogenerated.h
> 5 HOSTCC tools/aisimage.o
> 6 In file included from /usr/include/image.h:22:0,
> 7 from tools/aisimage.c:10:
> 8 /usr/include/rgbpixel.h:61:3: error: expected specifier-qualifier-list before 'RGBpixel'
> 9 In file included from tools/aisimage.c:10:0:
> 10 /usr/include/image.h:40:1: error: unknown type name 'class'
> 11 /usr/include/image.h:41:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
> 12 tools/aisimage.c:22:1: error: unknown type name 'table_entry_t'
> 13 tools/aisimage.c:23:2: warning: braces around scalar initializer [enabled by default]
> 14 tools/aisimage.c:23:2: warning: (near initialization for 'aisimage_cmds[0]') [enabled by default]
> [snip]
>
> As far as I understand the messages, it erroneously tries to include /usr/include/image.h instead of <wc>/include/image.h
>
> Can you confirm this error?
>

yes this is an issue with u-boot tools.

see tools/Makefile

HOST_EXTRACFLAGS += -include $(srctree)/include/libfdt_env.h \
         $(patsubst -I%,-idirafter%, $(UBOOTINCLUDE)) \


if you are lucky you can get away with adding image.h as a -include
like above. And yes this needs a decent solution one day.

Regards,
Jeroen