[U-Boot] [PATCH 2/3] board_r: run scsi init() on ARM too
Ian Campbell
ijc at hellion.org.uk
Mon Jul 21 20:23:18 CEST 2014
On Fri, 2014-07-18 at 21:12 -0600, Simon Glass wrote:
> Hi Ian,
>
> On 18 July 2014 13:38, Ian Campbell <ijc at hellion.org.uk> wrote:
> >
> > This has been disabled for ARM in initr_scsi since that function was
> > introduced. However it works fine for me on Cubieboard and Cubietruck (with the
> > upcoming AHCI glue patch).
> >
> > I also tested on two random ARM platforms which seem to define CONFIG_CMD_SCSI:
> > - highbank worked fine (on midway hardware)
> > - omap5_uevm built OK and I confirmed using objdump that things were as
> > expected (i.e. the default weak scsi_init nop was used).
> >
> > While there remove the mismatched comment from the #endif (omitting the comment
> > seems to be the prevailing style in this file) and add a missing return to
> > initr_doc which I happened to spot while editing.
>
> That's great, but I think the latter should be a separate patch.
I've just sent that out. So here is v3 of this patch. I noticed that you
acked v1 and I failed to pick that up so I've taken the liberty of
adding it here after removing the initr_doc change -- I hope that was
OK.
8<-------------------------
More information about the U-Boot
mailing list