[U-Boot] [U-Boot, 1/3] serial: ns16550: drop CONFIG_OMAP1610 from the special case

Tom Rini trini at ti.com
Tue Jul 22 21:22:38 CEST 2014


On Fri, Jul 11, 2014 at 08:29:02PM +0900, Masahiro Yamada wrote:

> If CONFIG_OMAP1610 is defined, the code returning the fixed value (26)
> is enabled. But this case is covered by the following code.
> 
> (CONFIG_SYS_NS16550_CLK + (gd->baudrate * (MODE_X_DIV / 2))) /
>     (MODE_X_DIV * gd->baudrate)
> = (48000000 + (115200 * (16 / 2))) / (16 * 115200)
> = 48921600 / 1843200
> = 26
> 
> The "#ifdef CONFIG_OMAP1610" was added by commit 6f21347d more than
> ten years ago. In those days, the divide-and-round was not used.
> I guess that is why this weird code was added here.
> 
> Signed-off-by: Masahiro Yamada <yamada.m at jp.panasonic.com>
> Cc: Tom Rini <trini at ti.com>
> Cc: Rishi Bhattacharya <rishi at ti.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140722/690d155e/attachment.pgp>


More information about the U-Boot mailing list