[U-Boot] [PATCH v3 2/9] arm: Set up global data before board_init_f()

[Tom Rini]

On Wed, Jul 23, 2014 at 06:16:52AM -0600, Simon Glass wrote:
> +Albert, Tom
> 
> Hi Albert,
> 
> On 11 July 2014 11:44, Jeroen Hofstee <dasuboot at myspectrum.nl> wrote:
> > Hello Simon,
> >
> >
> > On 11-07-14 06:23, Simon Glass wrote:
> >>
> >> At present arm defines CONFIG_SYS_GENERIC_GLOBAL_DATA, meaning that
> >> the global_data pointer is set up in board_init_f(). However it is
> >> actually set up before this, it just isn't zeroed.
> >>
> >> If we zero the global data before calling board_init_f() then we
> >> don't need to define CONFIG_SYS_GENERIC_GLOBAL_DATA.
> >>
> >> Make this change (on arm32 only) to simplify the init process. I
> >> don't have the ability to test aarch64 yet.
> >>
> >> Signed-off-by: Simon Glass <sjg at chromium.org>
> >> ---
> >>
> >> Changes in v3:
> >> - Fix assembler code comment in crt0.S to say GD, not BSS
> >> - Ensure that aarch64 stays as it was
> >> - Add newline after clr_gd label
> >> - Remove redundant mov r0, #0
> 
> Are you happy with this patch? I would like to apply to to the dm
> repo, but would quite like to get an ack first.

Acked-by: Tom Rini <trini at ti.com>

But still want Albert to chime in too.  He should be back now :)

> 
> >>
> >> Changes in v2: None
> >>
> >>   arch/arm/include/asm/config.h | 2 ++
> >>   arch/arm/lib/crt0.S           | 9 +++++++++
> >>   2 files changed, 11 insertions(+)
> >
> > Looks good to me. I picked up this one instead
> > of my memset version.
> 
> >
> > Thanks, Jeroen
> 
> Regards,
> Simon
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140723/4a4cf86c/attachment.pgp>