[U-Boot] [PATCH] Makefile: use $(shell ...) for determining file_size

Tom Rini trini at ti.com
Wed Jul 23 22:07:04 CEST 2014


On Wed, Jul 23, 2014 at 09:24:00PM +0200, Jeroen Hofstee wrote:
> Hi,
> 
> On 23-07-14 20:03, Tom Rini wrote:
> >On Wed, Jul 23, 2014 at 04:27:36AM -0600, Simon Glass wrote:
> >>On 22 July 2014 18:08, Chris Packham <judge.packham at gmail.com> wrote:
> >>>file_size was being calculated using back-ticks but map_size uses
> >>>$(shell ...). Update the file_size calculation to use $(shell ...).
> >>>
> >>>Signed-off-by: Chris Packham <judge.packham at gmail.com>
> >>Acked-by: Simon Glass <sjg at chromium.org>
> >>
> >>But you might want to look at this.
> >>
> >>http://patchwork.ozlabs.org/patch/371936/
> >Yeah, Jeroen, can we get a v2 of your patch that uses $(shell ... )?
> >Thanks!
> >
> >
> no problem. For the record I have not seen any issues with
> mentioned gmake version. But using $(shell .. ) seem like a sane
> thing to do. v2 is on its way, running MAKEALL for arm (can we keep it?).

MAKEALL isn't going away for v2014.10 but please reply to Simon's RFC
about it.  I do have to admit that switching all of my stuff to buildman
is still on my TODO list.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140723/64798183/attachment.pgp>


More information about the U-Boot mailing list