[U-Boot] [PATCH 3/6] sunxi: add Cubieboard2 support

[Ian Campbell]

On Fri, 2014-07-25 at 00:12 +0300, Siarhei Siamashka wrote:
> The multi-soc support (within the Allwinner A10/A13/A20 family) is the
> feature, which is scheduled for this merge window. It is a present
> piece of work.

I have never seen any such code, nor am I aware of any such thing being
"scheduled" for this merge window (who by?).

As far as I'm concerned this is not a goal for this merge window, if it
lands then that would be nice but I think you are either underestimating
the work involved or over estimating the size of the merge window.

> Your patch is related in the sense that it is detrimental to this goal.

No it is not. Whoever eventually wants to work on multi SoC support can
trivially build on this series.

> > > The newly added Cubieboard2 from your patch appears to be missing the
> > > important AXP209_POWER option. So the patch is not good enough to be
> > > pushed anywhere in its current form.
> > 
> > It works for me regardless and always has.
> 
> This simply means that your board is not very sensitive to the use of
> wrong voltages and may tolerate some abuse. You are just betting on
> luck.

The sunxi github tree had exactly the same lack of power controller
config issue and it appears to be fine for plenty of people.

Note that we have not yet merged FAST_MBUS into mainline.

> If you have been tracking the linux-sunxi mailing list, wrong voltages
> (dcdc3 in particular) have caused some very real reliability problems
> for some fraction of users. "Works for me" is not the right answer.
> 
> > The AXP209 config is trivial to add now that Hans has added the relevant code. 

And I have already sent a patch to do so.

> Yes. You can fix the problem after the fact, or you can avoid pushing
> the problematic commit in the first place and do something better.

We are not going to redo all of these patches from scratch as you seem
to be asking repeatedly for every trivial issue you have found in your
review of this series which I'm afraid is several weeks to late to be
useful.

Please base your work on what is currently in u-boot-sunxi#master, that
is now the baseline. Even if we *were* to redo the current stuff as you
are asking your work will still have to be based on that.

Ian.