[U-Boot] [linux-sunxi] Re: [PATCH 05/14] sunxi: dram: Code cleanup for the impedance calibration

[Ian Campbell]

On Fri, 2014-07-25 at 06:44 +0300, Siarhei Siamashka wrote:

> > I'd also steer clear of describing this as a code cleanup when it
> > also has functional changes.
> 
> The 'cleanup' was just a bad choice of word. It is a reimplementation.

Right, I think that's the crux of all issues raised (hence I didn't
respond to your comments, which looked good though, thanks). The commit
said clean up so I was expecting no (or few) functional changes, so all
the undescribed changes made me antsy.

I'd be happy with a patch described as reimplement (ideally with a more
comprehensive list of the changes in the changelog) or with a remove and
replace as you prefer.

Ian.