[U-Boot] [PATCH v4 1/1] ARM: kirkwood: add mvsdio driver

[drEagle]

Hi Stefan,

On 25/07/2014 09:15, Stefan Roese wrote:
> Hi Gerald,

> Thanks. But still some more comments below.

Thanks for the review.

Just sent a new version of the patch.

> I still don't see why this function is needed for the MMC driver. It seems to only be used from a debug() output. I suggest to remove it from this patch to not touch the general kirkwood stuff.
> 
> Also this MMC driver should be able to support multiple Marvells SoC's, right? So calling some "kirkwood" functions doesn't seem to be generic.

Agree, cleaned as requested.

> Again, please use the SPDX license identifier as done in all U-Boot sources now. This is mandatory!

Oops...

> BTW: You seem to be adding a new Kirkwood SoC version with this MMC patch. This really is not MMC related and should be split into a separate patch.

Will do this.

Enjoy,

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 538 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140725/d7027389/attachment.pgp>