[U-Boot] [PATCH v3 06/10] sunxi: Add sun5i support

[Hans de Goede]

Hi,

On 07/23/2014 08:02 PM, Siarhei Siamashka wrote:
> On Mon,  9 Jun 2014 11:36:58 +0200
> Hans de Goede <hdegoede at redhat.com> wrote:
>
>> Add support for the Allwinner A13 and A10s SoCs also know as the Allwinner
>> sun5i family, and the A13-OLinuXinoM A13 based and r7-tv-dongle A10s based
>> boards.
>>
>> The only differences compared to the already supported sun4i and sun7i
>> families are all in the DRAM controller initialization:
>>
>> -Different hcpr values
>> -Different MBUS settings
>> -Some other small initialization changes
>>
>> Signed-off-by: Henrik Nordstrom <henrik at henriknordstrom.net>
>> Signed-off-by: Stefan Roese <sr at denx.de>
>> Signed-off-by: Oliver Schinagl <oliver at schinagl.nl>
>> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
>> Acked-by: Ian Campbell <ijc at hellion.org.uk>
>> ---
>>   arch/arm/cpu/armv7/sunxi/Makefile   |  2 ++
>>   arch/arm/cpu/armv7/sunxi/board.c    | 12 ++++++++++++
>>   arch/arm/cpu/armv7/sunxi/cpu_info.c |  8 ++++++++
>>   arch/arm/cpu/armv7/sunxi/dram.c     | 21 +++++++++++++++++++++
>>   board/sunxi/Makefile                |  2 ++
>>   board/sunxi/dram_a13_oli_micro.c    | 32 ++++++++++++++++++++++++++++++++
>>   board/sunxi/dram_r7dongle.c         | 31 +++++++++++++++++++++++++++++++
>>   boards.cfg                          |  2 ++
>>   include/configs/sun5i.h             | 23 +++++++++++++++++++++++
>>   include/configs/sunxi-common.h      |  2 ++
>>   10 files changed, 135 insertions(+)
>>   create mode 100644 board/sunxi/dram_a13_oli_micro.c
>>   create mode 100644 board/sunxi/dram_r7dongle.c
>>   create mode 100644 include/configs/sun5i.h
>
> Even if there is a valid reason to bundle the addition of some example
> sun5i based board to boards.cfg

To address this first, I believe that it is a good idea when adding
functionality to also enable it, otherwise one is just adding dead code.

> with the changes needed for sun5i SoC
> variant, why is it *two* boards this time?

Because there are 2 sun5i variants A13 and A10s

Regards,

Hans