[U-Boot] [PATCH] usb: ehci: rmobile: Add support R8A7794

Nobuhiro Iwamatsu nobuhiro.iwamatsu.yj at renesas.com
Mon Jul 28 08:17:29 CEST 2014


Hi, Marek.

Thanks for your review.

2014-07-25 6:38 GMT+09:00 Marek Vasut <marex at denx.de>:
> On Thursday, July 24, 2014 at 07:52:07 AM, Nobuhiro Iwamatsu wrote:
>> R8A7794 has same IP of USB controller as R8A7790 and R8A7791.
>> This addes support for R8A7794.
>>
>> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj at renesas.com>
>> ---
>>  drivers/usb/host/ehci-rmobile.c | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/drivers/usb/host/ehci-rmobile.c
>> b/drivers/usb/host/ehci-rmobile.c index 049e4c4..29b4a93 100644
>> --- a/drivers/usb/host/ehci-rmobile.c
>> +++ b/drivers/usb/host/ehci-rmobile.c
>> @@ -29,6 +29,12 @@ static u32
>> usb_base_address[CONFIG_USB_MAX_CONTROLLER_COUNT] = { 0xEE0C0000,     /* USB1
>> */
>>       0xEE000000      /* USB3 (USB3.0 Host)*/
>
> Just a side-note ... Will this one USB3 controller above really work with the
> EHCI driver ? I know there is a compat mode for xHCI, but I'm not quite sure
> it's this easy to make it operational.

You are right.
ehci-rmobile.c cannot handle USB 3.0.
I send a patch for corrections immediately.

>
>>  };
>> +#elif defined(CONFIG_R8A7794)
>> +static u32 usb_base_address[CONFIG_USB_MAX_CONTROLLER_COUNT] = {
>> +     0xEE080000,     /* USB0 (EHCI) */
>> +     0xEE0C0000,     /* USB1 */
>> +     /* R8A7794 does not have USB 3.0. */
>> +};
>>  #else
>>  #error rmobile EHCI USB driver not supported on this platform
>>  #endif
>
> Applied, thanks.

Thank you.

>
> Best regards,
> Marek Vasut

Best regards,
  Nobuhiro

-- 
Nobuhiro Iwamatsu


More information about the U-Boot mailing list