[U-Boot] [PATCH v5 09/15] tools: add genboardscfg.py

[Masahiro Yamada]

Hi Simon,


On Mon, 28 Jul 2014 04:14:17 +0100
Simon Glass <sjg at chromium.org> wrote:

> Hi Masahiro,
> 
> On 27 July 2014 10:05, Masahiro Yamada <yamada.m at jp.panasonic.com> wrote:
> > Hi Simon,
> >
> >
> >
> > On Sat, 26 Jul 2014 01:17:02 +0100
> > Simon Glass <sjg at chromium.org> wrote:
> >
> >> > +
> >> > +import sys
> >> > +import os
> >> > +import errno
> >> > +import shutil
> >> > +import time
> >> > +import subprocess
> >> > +import fnmatch
> >> > +import glob
> >> > +import re
> >> > +import optparse
> >>
> >> You can sort the imports.
> >
> >
> > Sorted alphabetially in v6.
> >
> > Pardon my ignorance, but is there any coding style guide
> > about sorting imports?
> 
> Not really. I have been following PEP8 (which I don't think mentions
> this), but in general in U-Boot we try to sort include files.


I checked PEP8.


PEP8 says as follow in terms of imports:
--------------->8------------------
Imports should be grouped in the following order:

 1. standard library imports
 2. related third party imports
 3. local application/library specific imports
---------------8<-------------------

But the order in each group is not mentioned.





Best Regards
Masahiro Yamada