[U-Boot] [PATCH v3 15/16] RFC: dm: tegra: Enable driver model for serial

Stephen Warren swarren at wwwdotorg.org
Thu Jul 31 22:18:50 CEST 2014


On 07/30/2014 03:49 AM, Simon Glass wrote:
> Use driver model for serial ports (for test and comment only).

A couple of nits:

> diff --git a/include/configs/tegra-common.h b/include/configs/tegra-common.h

>   #define CONFIG_SYS_MALLOC_LEN		(4 << 20)	/* 4MB  */
> +#define CONFIG_SYS_MALLOC_F_LEN	(1 << 10)

README says:

                 Pre-relocation malloc() is only supported on sandbox
                 at present but is fairly easy to enable for other archs.

I assume that should be deleted now.

>
>   /*
>    * NS16550 Configuration
>    */
> -#define CONFIG_SYS_NS16550
> +#ifdef CONFIG_SPL_BUILD
>   #define CONFIG_SYS_NS16550_SERIAL
>   #define CONFIG_SYS_NS16550_REG_SIZE	(-4)
>   #define CONFIG_SYS_NS16550_CLK		V_NS16550_CLK
> +#endif
> +#define CONFIG_SYS_NS16550

Leaving that define in the same place would simplify the diff.


More information about the U-Boot mailing list