[U-Boot] [PATCH 4/4] cm-t54: add cm-t54 board support

[Tom Rini]

On Sun, Apr 27, 2014 at 01:17:28PM +0300, Dmitry Lifshitz wrote:

> Add cm-t54 board directory, config file. Enable build.
[snip]
> diff --git a/board/compulab/cm_t54/Makefile b/board/compulab/cm_t54/Makefile
> new file mode 100644
> index 0000000..bd8bc51
> --- /dev/null
> +++ b/board/compulab/cm_t54/Makefile
> @@ -0,0 +1,10 @@
> +#
> +# Copyright (C) 2014 Compulab Ltd - http://compulab.co.il/
> +#
> +# Author: Dmitry Lifshitz <lifshitz at compulab.co.il>
> +#
> +# SPDX-License-Identifier:	GPL-2.0+
> +#
> +
> +obj-y += $(BOARD).o

Please don't use $(BOARD) here, just went and changed the other users of
this convention.

> +/*
> + * Routine: board_init
> + * Description: hardware init.
> + */
> +int board_init(void)
> +{
> +	gd->bd->bi_boot_params = (0x80000000 + 0x100); /* boot param addr */
> +
> +	return 0;
> +}

CONFIG_SYS_SDRAM_BASE + 0x100

> +#define CONFIG_EXTRA_ENV_SETTINGS \
> +	"loadaddr=0x82000000\0" \
> +	"fdtaddr=0x80F80000\0" \
> +	"fdt_high=0xffffffff\0" \
> +	"rdaddr=0x81000000\0" \

Can you use DEFAULT_LINUX_BOOT_ENV here (see u-boot-ti) ?  I really
don't like disabling fdt relocation with it being below 128MB (I'd
prefer what we do with DEFAULT_LINUX_BOOT_ENV and bootm_size, please see
the various ML threads about that).

Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140506/06f19a06/attachment.pgp>