[U-Boot] [PATCH 4/4] cm-t54: add cm-t54 board support

[Igor Grinberg]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Tom,

On 05/06/14 20:45, Tom Rini wrote:
> On Sun, Apr 27, 2014 at 01:17:28PM +0300, Dmitry Lifshitz wrote:
> 
>> Add cm-t54 board directory, config file. Enable build.
> [snip]
>> diff --git a/board/compulab/cm_t54/Makefile b/board/compulab/cm_t54/Makefile
>> new file mode 100644
>> index 0000000..bd8bc51
>> --- /dev/null
>> +++ b/board/compulab/cm_t54/Makefile
>> @@ -0,0 +1,10 @@
>> +#
>> +# Copyright (C) 2014 Compulab Ltd - http://compulab.co.il/
>> +#
>> +# Author: Dmitry Lifshitz <lifshitz at compulab.co.il>
>> +#
>> +# SPDX-License-Identifier:	GPL-2.0+
>> +#
>> +
>> +obj-y += $(BOARD).o
> 
> Please don't use $(BOARD) here, just went and changed the other users of
> this convention.
> 
>> +/*
>> + * Routine: board_init
>> + * Description: hardware init.
>> + */
>> +int board_init(void)
>> +{
>> +	gd->bd->bi_boot_params = (0x80000000 + 0x100); /* boot param addr */
>> +
>> +	return 0;
>> +}
> 
> CONFIG_SYS_SDRAM_BASE + 0x100
> 
>> +#define CONFIG_EXTRA_ENV_SETTINGS \
>> +	"loadaddr=0x82000000\0" \
>> +	"fdtaddr=0x80F80000\0" \
>> +	"fdt_high=0xffffffff\0" \
>> +	"rdaddr=0x81000000\0" \
> 
> Can you use DEFAULT_LINUX_BOOT_ENV here (see u-boot-ti) ?  I really
> don't like disabling fdt relocation with it being below 128MB (I'd
> prefer what we do with DEFAULT_LINUX_BOOT_ENV and bootm_size, please see
> the various ML threads about that).

Thanks Tom,

We will fix the comments and repost v2 in a couple of days.

- -- 
Regards,
Igor.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQIcBAEBAgAGBQJTcwroAAoJEBDE8YO64EfaxQoP/2GKp8kJErMdiMZs8TdIhkGp
De1T6qw+qoTsA/91nFQUq4AMv5lfApghTgjmU/zx5oI4Uo8IPE8uMtZw9VSwTucu
Zfy1BrhGj8kbVe9u6oOf2uZiqvzyaEqdi9a/EwmB69cYu8QcQFP+nbPPMqmxgA2i
B9aUP/+54PluWcBDN0Z5btPfeRBgodyHLJlOtNWCwy4SmzgoARYbS+wrrKqiZApJ
NPYdH1wtgVcrsqiBFGILCktgVkUl4ncC7oa0MTzQfzAPKaKvbhbuwT98lhgUNcsZ
xf7QS3KSGD6/H8xZS0VTAmC5frf7/IAHzSFJsb25OMfi8gwrL8a1Nf9XA+UaAB0I
cpv53xxEoTvdAP/gmBz0sKdC0YKLvYin/OqY0PeFl1itPrKJ1CiKBXL60l0u7wkT
J4HtxsUUfl/nbZc/KbB9cnYCf57V1nnDw3KesRR2nwWaBf0dTWFiPIKCHpZjyUKg
OUinqCjRIbL6KTLEkcipPYXHuFGVNqcE3a+uRDn7jLW0+XcU2zKi04Djpn7F84TM
LXUhnJX8UC59AZuseMqi3yK26OOmTFcIOMcRDi45Zri3qsaYIi7TrD9offwlxb6/
+JEP3YROi0fm8jrC//0GUjx8idmjeZYlx0U4EDjLxKBqnABVlTjrBoiheB+rr+f0
t2HoJHgnV89Dtu26mZi5
=C1e2
-----END PGP SIGNATURE-----