[U-Boot] [Bug Report] Patman removes author's Signed-off-by credit

Masahiro Yamada yamada.m at jp.panasonic.com
Wed May 14 06:17:02 CEST 2014


Hi Simon,

I suspect there is something wrong with Patman
since commit 102061bd (patman: Avoid duplicate sign-offs).


For example, my commit log is like follows

    sandbox: set sandbox's vendor to null
    
    Because sandbox is not a real hardware, setting vendor=sandbox is
    almost meaningless.
    
    This commit sets sandbox's vendor field to '-'.
    
    It is a good thing that it decreases one level directory hierarchy.
    The files board/sandbox/sandbox/* have been moved to board/sandbox/*.
    
    Signed-off-by: Masahiro Yamada <yamada.m at jp.panasonic.com>
    Acked-by: Simon Glass <sjg at chromium.org>
    Series-to: uboot
    Series-cc: sjg
    Series-version: 2
    Series-changes: 2
      - Rebase


When I run "tools/patman/patman -c 1",
Patman removes all Signed-off-by credits and checkpatch.pl
reports missing Signed-off-by credit error.



    1 errors, 0 warnings, 0 checks for 0001-sandbox-set-sandbox-s-vendor-to-null.patch:
    error: <unknown>,0: Missing Signed-off-by: line(s)
    
    checkpatch.pl found 1 error(s), 0 warning(s), 0 checks(s)


I think this is worse than dupulicated signed-off-by.


Best Regards
Masahiro Yamada



More information about the U-Boot mailing list