[U-Boot] [PATCH v3 11/11] imx: ventana: switch to SPL

[Stefano Babic]

Hi Tim,

On 30/05/2014 06:52, Tim Harvey wrote:
> On Thu, May 29, 2014 at 12:02 AM, Stefano Babic <sbabic at denx.de> wrote:
>> Hi Tim,
>>
>> I cannot build with this version. A setup for a couple of pins is not
>> yet replaces.
>>
>> In fact, I have:
>>
>>         /* Enable Backlight */
>>        imx_iomux_v3_setup_pad(MX6_PAD_SD1_CMD__GPIO1_IO18 |
>>
>> and it should be:
>>
>>  SETUP_IOMUX_PAD(PAD_SD1_CMD__GPIO1_IO18 |
>>
>> The same some lines later:
>>
>>         /* Backlight CABEN on LVDS connector */
>> -       imx_iomux_v3_setup_pad(MX6_PAD_SD2_CLK__GPIO1_IO10 |
>> +       SETUP_IOMUX_PAD(PAD_SD2_CLK__GPIO1_IO10 |
>>
>>
>> Can you check and fix it ? Thanks !
>>
>> Regarding your patchset: I had no remarkable comments and, as I have not
>> seen any comments from other developers, your patchset is ready to be
>> merged. I am also waiting for Masahiro's patch to be applied.
>>
>> Best regards,
>> Stefano Babic
>>
> 
> Stefano,
> 
> Those should be patched from patch 10.

Sure ? Patch 10 replaces a lot of occurrencies, but I do not see the
ones introduced by "imx: ventana: add HDMI and LVDS display capability"
that is already applied.

> However, I can't seem to get
> patch 9 to apply cleanly from current u-boot-imx/master so perhaps I
> should just rebase the whole series and post again?

Please take a look and repost if required. If you repost, you could also
fix yourself this styling issue in Patch 3:

ERROR: return is not a function, parentheses are not required
#192: FILE: drivers/mtd/nand/mxs_nand_spl.c:138:
+	return (chip->oob_poi[0] != 0xff);

Regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================