[U-Boot] [PATCH 4/5] usb: s3c-otg: Allow custom gusbcfg

[Marek Vasut]

On Tuesday, November 04, 2014 at 08:36:57 PM, Pavel Machek wrote:
> On Tue 2014-11-04 06:07:33, Marek Vasut wrote:
> > Allow passing in a custom configuration of the gusbcfg register
> > via platform data.
> > 
> > Signed-off-by: Marek Vasut <marex at denx.de>
> > Cc: Chin Liang See <clsee at altera.com>
> > Cc: Dinh Nguyen <dinguyen at opensource.altera.com>
> > Cc: Vince Bridgers <vbridger at altera.com>
> 
> Acked-by: Pavel Machek <pavel at denx.de>
> 
> >  	debug("Reseting OTG controller\n");
> > 
> > -	writel(0<<15		/* PHY Low Power Clock sel*/
> > +	dflt_gusbcfg =
> > +		0<<15		/* PHY Low Power Clock sel*/
> > 
> >  		|1<<14		/* Non-Periodic TxFIFO Rewind Enable*/
> >  		|0x5<<10	/* Turnaround time*/
> >  		|0<<9 | 0<<8	/* [0:HNP disable,1:HNP enable][ 0:SRP disable*/
> > 
> > @@ -413,8 +415,12 @@ static void reconfig_usbd(void)
> > 
> >  		|0<<6		/* 0: high speed utmi+, 1: full speed serial*/
> >  		|0<<4		/* 0: utmi+, 1:ulpi*/
> >  		|1<<3		/* phy i/f  0:8bit, 1:16bit*/
> > 
> > -		|0x7<<0,	/* HS/FS Timeout**/
> > -		&reg->gusbcfg);
> > +		|0x7<<0;	/* HS/FS Timeout**/
> > +
> 
> "Interesting" comment style. And I'd remove 0x prefixes from constants
> <8...

Lukasz, what do you say to just convert those four boards to use the gusbcfg
platform data afterward ?

btw. you can find the latest version in u-boot-usb:topic/s3c-otg

Best regards,
Marek Vasut