[U-Boot] [PATCH v3] sunxi: video: Add simplefb support

[Hans de Goede]

Hi,

On 11/17/2014 10:35 AM, Grant Likely wrote:
> On Sun, Nov 16, 2014 at 7:39 PM, Hans de Goede <hdegoede at redhat.com> wrote:
>> From: Luc Verhaegen <libv at skynet.be>
>>
>> Add simplefb support, note this depends on the kernel having support for
>> the clocks property which has recently been added to the simplefb devicetree
>> binding.
>>
>> Signed-off-by: Luc Verhaegen <libv at skynet.be>
>> [hdegoede at redhat.com: Use pre-populated simplefb node under /chosen as
>>  disussed on the devicetree list]
>> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
> 
> I'm not a U-Boot maintainer, so take my comments with a grain of salt...
> 
> This patch seems quite short sighted. The code that calculates and
> updates the simple framebuffer node addresses is pretty much going to
> be identical for all platforms. Why is sunxi open coding it?
> Particularly when there could be fiddly bits around dealing with
> #address-cells/#size-cells.
> 
> I would think the code to update a simplefb node would be a common
> library function.

You're right I've spun it out into a generic helper function for the
next version of this patch-set.

Regards,

Hans