[U-Boot] [PATCH v2 01/12] spi/ich.c: Fix a bug of reading from a non-64 bytes aligned address

Bin Meng bmeng.cn at gmail.com
Tue Nov 25 04:13:42 CET 2014


Hi Simon

On Tue, Nov 25, 2014 at 11:10 AM, Simon Glass <sjg at chromium.org> wrote:
> Hi,
>
> On 1 November 2014 at 02:53, Bin Meng <bmeng.cn at gmail.com> wrote:
>> The ich spi controller driver spi_xfer() tries to align reading
>> address to 64 bytes when doing spi data in, which causes a bug of
>> either infinite loop or a huge size memcpy().
>>
>> Actually the ich spi controller does not have such requirement of
>> 64 bytes alignment when reading data from spi slave devices.
>>
>> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
>> Acked-by: Simon Glass <sjg at chromium.org>
>> Tested-by: Simon Glass <sjg at chromium.org>
>> ---
>>  drivers/spi/ich.c | 17 ++---------------
>>  1 file changed, 2 insertions(+), 15 deletions(-)
>
> Any update on this series?
>
> If the series is acceptable I could bring it in through the x86 tree
> since it relates to that SPI controller.
>

Thanks for tracking this series. I was asking the same question to
Jagan yesterday.

Regards,
Bin


More information about the U-Boot mailing list