[U-Boot] [PATCH v2 01/12] spi/ich.c: Fix a bug of reading from a non-64 bytes aligned address

Simon Glass sjg at chromium.org
Wed Nov 26 17:03:48 CET 2014


Hi Jagan,

On 24 November 2014 at 20:13, Bin Meng <bmeng.cn at gmail.com> wrote:
> Hi Simon
>
> On Tue, Nov 25, 2014 at 11:10 AM, Simon Glass <sjg at chromium.org> wrote:
>> Hi,
>>
>> On 1 November 2014 at 02:53, Bin Meng <bmeng.cn at gmail.com> wrote:
>>> The ich spi controller driver spi_xfer() tries to align reading
>>> address to 64 bytes when doing spi data in, which causes a bug of
>>> either infinite loop or a huge size memcpy().
>>>
>>> Actually the ich spi controller does not have such requirement of
>>> 64 bytes alignment when reading data from spi slave devices.
>>>
>>> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
>>> Acked-by: Simon Glass <sjg at chromium.org>
>>> Tested-by: Simon Glass <sjg at chromium.org>
>>> ---
>>>  drivers/spi/ich.c | 17 ++---------------
>>>  1 file changed, 2 insertions(+), 15 deletions(-)
>>
>> Any update on this series?
>>
>> If the series is acceptable I could bring it in through the x86 tree
>> since it relates to that SPI controller.
>>
>
> Thanks for tracking this series. I was asking the same question to
> Jagan yesterday.

Let me know if you want to pull this through the SPI tree, otherwise
I'll go ahead (iwc I'll need to test once more first).

Regards,
Simon


More information about the U-Boot mailing list