[U-Boot] [PATCH 2/2] Exynos5800: The Peach-Pi board does not have a Parade video bridge

[Simon Glass]

Hi Sjoerd,

On 24 November 2014 at 16:13, Sjoerd Simons
<sjoerd.simons at collabora.co.uk> wrote:
> On Mon, 2014-11-24 at 09:50 -0700, Simon Glass wrote:
>> Hi Sjoerd,
>>
>> On 24 November 2014 at 09:21, Sjoerd Simons
>> <sjoerd.simons at collabora.co.uk> wrote:
>> > On Mon, 2014-11-24 at 09:01 -0700, Simon Glass wrote:
>> >> Does it fix the problem if you just remove it from the device tree?
>> >
>> > That should indeed work as well, but i haven't tested it thusfar.
>> >
>> > Would you simply like to see that tested, or are you suggesting to keep
>> > CONFIG_VIDEO_PARADE around ?
>>
>> Some background - I'd like to have an exynos5-dt board config which is
>> used by the various Chromebooks (and perhaps other boards to) where
>> the only difference is the device tree. At present the peach-pi.h file
>> is mostly identical to peach-pit.h, so then we can avoid #ifdefs in
>> the code, etc.
>
> That sounds great to me as a goal. However, having to #define
> CONFIG_VIDEO_PARADE in a board config for an 5420/5800 based device if
> you also define CONFIG_LCD seems somewhat awkward.
>
> I'll happily admit that i'm not very familiar with u-boot. Is that
> something that's generally accepted and/or can we define such a
> dependency in the build system in some way?

We have traditionally done what you did - i.e. fully specify
everything. But I'd like to move to a model where the device tree
controls what devices are available, and we have generic boards (like
exynos5-dt) where we worry a bit less about image size, etc. It's
great for getting people going quickly without having to mess with the
code.

>
>> For memory size we can specify it with device tree, although the patch
>> for this has yet to land.
>>
>> So in general I'm keen for this peach-pi.h file to go away and be
>> replaced with a CONFIG_DEFAULT_DEVICE_TREE line in the defconfig. If
>> all you need to change is the device tree then that is best.
>
> I'll respin with just the device-tree change tomorrow (need to run out
> for the evening) and potentially add a patch which preemptively moves
> the non-peach-pi specific stuff into exynos5-dt so the pit/pi configs
> can be their minimal. Thanks for your background info & feedback!

Sounds good. You can include exynos5-dt-common.h which was provided
for that purpose. I just haven't got to it yet.

Regards,
Simon