[U-Boot] [PATCH v3] imx6: add Bachmann OT1200 board

Masahiro Yamada yamada.m at jp.panasonic.com
Thu Oct 2 14:12:28 CEST 2014


Hi Christian,


On Thu,  2 Oct 2014 13:33:46 +0200
Christian Gmeiner <christian.gmeiner at gmail.com> wrote:

> --- /dev/null
> +++ b/board/bachmann/ot1200/Kconfig
> @@ -0,0 +1,23 @@
> +if TARGET_OT1200
> +
> +config SYS_CPU
> +	string
> +	default "armv7"
> +
> +config SYS_BOARD
> +	string
> +	default "ot1200"
> +
> +config SYS_VENDOR
> +	string
> +	default "bachmann"
> +
> +config SYS_SOC
> +	string
> +	default "mx6"
> +
> +config SYS_CONFIG_NAME
> +	string
> +	default "ot1200"
> +


The type "string" is not mandatory since
commit 461be2f96e4b87e5065208c6659a47dd0ad9e9f8.
You can save 5 lines.

Since it is not a big deal,
I don't think you have to resend it just for fixing this.
(I am just pointing out a minor thing I found by chance.)

If you like or you have a chance to send v4 for another fix,
I recommend you to drop "string".


Best Regards
Masahiro Yamada


More information about the U-Boot mailing list