[U-Boot] [PATCH v3] fix get_ram_size memory corruption

Wolfgang Denk wd at denx.de
Tue Oct 21 16:04:41 CEST 2014


Dear Gerd,

In message <1413894504-26255-1-git-send-email-kraxel at redhat.com> you wrote:
> base[0] is saved, but only restored in case the ram test failed.

When posting a new version of a patch please always make sure to add a
change log!

I'm afraid your patch breaks at least some boards;  tested on TQM5200
board...

Before (v2014.10):

	U-Boot 2014.10 (Oct 21 2014 - 15:59:47)

	CPU:   MPC5200B v2.2, Core v1.4 at 396 MHz
	       Bus 132 MHz, IPB 132 MHz, PCI 66 MHz
	Board: TQM5200S (TQ-Components GmbH)
	       on a STK52xx carrier board
	I2C:   85 kHz, ready
	DRAM:  64 MiB
	Flash: 32 MiB
	In:    serial
	Out:   serial
	Err:   serial
	Net:   FEC
	IDE:   Bus 0: OK 
	...

With your patch:

	U-Boot 2014.10-00001-g27030e7 (Oct 21 2014 - 15:45:12)

	CPU:   MPC5200B v2.2, Core v1.4 at 396 MHz
	       Bus 132 MHz, IPB 132 MHz, PCI 66 MHz
	Board: TQM5200S (TQ-Components GmbH)
	       on a STK52xx carrier board
	I2C:   85 kHz, ready
	DRAM:  1 GiB
[board hangs here]

Note also the incorrect RAM size.


Sorry, but this is not a correct fix.  NAK.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"It's when they say 2 + 2 = 5 that I begin to argue."    - Eric Pepke


More information about the U-Boot mailing list