[U-Boot] [Question of dm serial] Is pending handler optional?

Simon Glass sjg at chromium.org
Thu Oct 23 21:15:06 CEST 2014


Hi Masahiro,

On 23 October 2014 13:10, Masahiro YAMADA <yamada.m at jp.panasonic.com> wrote:
> Hi Simon,
>
>
>
> 2014-10-24 3:34 GMT+09:00 Simon Glass <sjg at chromium.org>:
>
>>
>> Yes it is actually mandatory, since we really don't want drivers to
>> block in their getc()/putc() methods.
>
> If so, could you update this comment block, please?

OK

>
> I think the comment "This method is optional" is misleading.
>
>
>> Output character check is required so we can implement flush. E.g.
>> when we change the baud rate we should flush first.
>
> OK, I will implement this way; .handler returns 0
> input and output FIFO are both empty, returns 1 otherwise. Is this correct?
> (My hardware cannot know how many characters are available in the FIFO.)
>

Well in one case (input=true) it should check the input and in the
other the output.

Regards,
Simon


More information about the U-Boot mailing list