[U-Boot] [PATCH v2 3/8] dm: serial: remove unnecessary casting

Masahiro YAMADA yamada.m at jp.panasonic.com
Thu Oct 23 21:19:06 CEST 2014


Hi Simon,


2014-10-24 4:03 GMT+09:00 Simon Glass <sjg at chromium.org>:
> Hi,
>
> On 23 October 2014 12:45, Simon Glass <sjg at chromium.org> wrote:
>> Hi Masahiro,
>>
>> On 23 October 2014 07:26, Masahiro Yamada <yamada.m at jp.panasonic.com> wrote:
>>> The type (void *) can be directly passed to a function that
>>> takes a specific pointer type.
>>>
>>> Signed-off-by: Masahiro Yamada <yamada.m at jp.panasonic.com>
>
> Thinking a bit more we may as well take this, the value of the
> explicit type is very small.
>
> Acked-by: Simon Glass <sjg at chromium.org>


Setting aside my comments in the log, I like at least this code chage.

I admit the description was not nice as you pointed out.


If you like, you can rephrase the comments
or squash 3/8 and 4/8 into a single patch removing comments in this patch.
Of course, it is OK to leave it as is.
Up to you.



-- 
Best Regards
Masahiro Yamada


More information about the U-Boot mailing list