[U-Boot] [PATCH v2 3/8] dm: serial: remove unnecessary casting

Simon Glass sjg at chromium.org
Fri Oct 24 05:54:48 CEST 2014


On 23 October 2014 13:19, Masahiro YAMADA <yamada.m at jp.panasonic.com> wrote:
> Hi Simon,
>
>
> 2014-10-24 4:03 GMT+09:00 Simon Glass <sjg at chromium.org>:
>> Hi,
>>
>> On 23 October 2014 12:45, Simon Glass <sjg at chromium.org> wrote:
>>> Hi Masahiro,
>>>
>>> On 23 October 2014 07:26, Masahiro Yamada <yamada.m at jp.panasonic.com> wrote:
>>>> The type (void *) can be directly passed to a function that
>>>> takes a specific pointer type.
>>>>
>>>> Signed-off-by: Masahiro Yamada <yamada.m at jp.panasonic.com>
>>
>> Thinking a bit more we may as well take this, the value of the
>> explicit type is very small.
>>
>> Acked-by: Simon Glass <sjg at chromium.org>
>
>
> Setting aside my comments in the log, I like at least this code chage.
>
> I admit the description was not nice as you pointed out.
>
>
> If you like, you can rephrase the comments
> or squash 3/8 and 4/8 into a single patch removing comments in this patch.
> Of course, it is OK to leave it as is.
> Up to you.

I think it is fairly clear what is going on.

Applied to u-boot-dm/master, thanks!


More information about the U-Boot mailing list