[U-Boot] [PATCH v3 4/8] common: spl: Add interactive DDR debugger support for SPL image

Albert ARIBAUD albert.u.boot at aribaud.net
Mon Oct 27 10:29:49 CET 2014


Hello Alison,

On Fri, 17 Oct 2014 16:00:30 +0800, Alison Wang <b18965 at freescale.com>
wrote:
> To support interactive DDR debugger, cli_simple.o, cli.o, cli_readline.o,
> command.o, s_record.o, xyzModem.o and cmd_disk.o are all needed for
> drivers/ddr/fsl/interactive.c.
> 
> In current common/Makefile, the above .o files are only produced when
> CONFIG_SPL_BUILD is disabled.
> 
> For LS102xA, interactive DDR debugger is needed in SD/NAND boot too, and
> I enabled CONFIG_FSL_DDR_INTERACTIVE. But according to the current
> common/Makfile, all the above .o files are not produced in SPL part
> because CONFIG_SPL_BUILD is enabled in SPL part, the following error
> will be shown,
> 
> drivers/ddr/fsl/built-in.o: In function `fsl_ddr_interactive':
> /home/wangh/layerscape/u-boot/drivers/ddr/fsl/interactive.c:1871:
> undefined reference to `cli_readline_into_buffer'
> /home/wangh/layerscape/u-boot/drivers/ddr/fsl/interactive.c:1873:
> undefined reference to `cli_simple_parse_line'
> make[1]: *** [spl/u-boot-spl] Error 1
> make: *** [spl/u-boot-spl] Error 2
> 
> So this patch fixed this issue and the above .o files will be produced
> no matter CONFIG_SPL_BUILD is enabled or disabled.
> 
> Signed-off-by: Alison Wang <alison.wang at freescale.com>
> ---
> Change log:
>  v3: Gave more explaination in the commit.
>  v2: No change.

This does not apply cleanly. Could you rebase and resubmit?

Amicalement,
-- 
Albert.


More information about the U-Boot mailing list