[U-Boot] [PATCH v1 1/1] odroid: Turn blue LED on in u-boot

Przemyslaw Marczak p.marczak at samsung.com
Mon Oct 27 12:35:18 CET 2014


Hello Suriyan,

On 10/10/2014 12:20 AM, Suriyan Ramasami wrote:
> To indicate that u-boot is active turn on the blue LED.
>
> Signed-off-by: Suriyan Ramasami <suriyan.r at gmail.com>
> ---
>   board/samsung/odroid/odroid.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/board/samsung/odroid/odroid.c b/board/samsung/odroid/odroid.c
> index fd5d2d2..391a287 100644
> --- a/board/samsung/odroid/odroid.c
> +++ b/board/samsung/odroid/odroid.c
> @@ -374,6 +374,9 @@ static void board_gpio_init(void)
>   	gpio_set_pull(EXYNOS4X12_GPIO_X31, S5P_GPIO_PULL_UP);
>   	gpio_set_drv(EXYNOS4X12_GPIO_X31, S5P_GPIO_DRV_4X);
>   	gpio_direction_input(EXYNOS4X12_GPIO_X31);
> +
> +	/* Enable blue LED */

Here you will need to add gpio_request() call, e.g.
http://patchwork.ozlabs.org/patch/403197/


> +	gpio_direction_output(EXYNOS4X12_GPIO_C10, 0);
>   }
>
>   static int pmic_init_max77686(void)
>

This looks good, but please wait until the patch series merge:
http://patchwork.ozlabs.org/patch/403186/ (starts from this commit)

Best regards,
-- 
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com


More information about the U-Boot mailing list