[U-Boot] [PATCH v1 1/1] odroid: Turn blue LED on in u-boot

[Suriyan Ramasami]

Hello Przemyslaw Marczak,

On Mon, Oct 27, 2014 at 4:35 AM, Przemyslaw Marczak
<p.marczak at samsung.com> wrote:
> Hello Suriyan,
>
> On 10/10/2014 12:20 AM, Suriyan Ramasami wrote:
>>
>> To indicate that u-boot is active turn on the blue LED.
>>
>> Signed-off-by: Suriyan Ramasami <suriyan.r at gmail.com>
>> ---
>>   board/samsung/odroid/odroid.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/board/samsung/odroid/odroid.c b/board/samsung/odroid/odroid.c
>> index fd5d2d2..391a287 100644
>> --- a/board/samsung/odroid/odroid.c
>> +++ b/board/samsung/odroid/odroid.c
>> @@ -374,6 +374,9 @@ static void board_gpio_init(void)
>>         gpio_set_pull(EXYNOS4X12_GPIO_X31, S5P_GPIO_PULL_UP);
>>         gpio_set_drv(EXYNOS4X12_GPIO_X31, S5P_GPIO_DRV_4X);
>>         gpio_direction_input(EXYNOS4X12_GPIO_X31);
>> +
>> +       /* Enable blue LED */
>
>
> Here you will need to add gpio_request() call, e.g.
> http://patchwork.ozlabs.org/patch/403197/
>

OK, I shall do that.

>
>> +       gpio_direction_output(EXYNOS4X12_GPIO_C10, 0);
>>   }
>>
>>   static int pmic_init_max77686(void)
>>
>
> This looks good, but please wait until the patch series merge:
> http://patchwork.ozlabs.org/patch/403186/ (starts from this commit)
>

OK, I shall send a v2 with the gpio_request() call after the patch
series you have mentioned merges.
Thanks!
- Suriyan

> Best regards,
> --
> Przemyslaw Marczak
> Samsung R&D Institute Poland
> Samsung Electronics
> p.marczak at samsung.com