[U-Boot] [PATCH 3/3] common: introduce board_preboot_os hook

Nikita Kiryanov nikita at compulab.co.il
Wed Oct 29 16:34:59 CET 2014


Hi Jeroen, Otavio,

On 29/10/14 17:23, Otavio Salvador wrote:
> On Wed, Oct 29, 2014 at 11:28 AM, Jeroen Hofstee <jeroen at myspectrum.nl> wrote:
>> On 29-10-14 14:08, Nikita Kiryanov wrote:
>>>
>>> Introduce board specific function board_preboot_os() to allow for board
>>> specific config before we boot, and use it on cm_fx6 to power off sata
>>> so that Linux will be able to setup it correctly.
>>>
>>> Signed-off-by: Nikita Kiryanov <nikita at compulab.co.il>
>>> Cc: Igor Grinberg <grinberg at compulab.co.il>
>>> Cc: Stefano Babic <sbabic at denx.de>
>>> Cc: Tom Rini <trini at ti.com>
>>
>> ..
>>>
>>> +
>>> +void board_preboot_os(void)
>>> +{
>>> +       cm_fx6_sata_power(0);
>>> +}
>>>    +/* Allow for board specific config before we boot */
>>> +__weak void board_preboot_os(void)
>>> +{
>>> +       /* please define board specific board_preboot_os() */
>>> +}
>>> +
>>>    int boot_selected_os(int argc, char * const argv[], int state,
>>>                       bootm_headers_t *images, boot_os_fn *boot_fn)
>>>    {
>>>          arch_preboot_os();
>>> +       board_preboot_os();
>>>          boot_fn(state, argc, argv, images);
>>
>>
>> Can you also add a prototype for the board_preboot_os in say
>> bootm.h or similiar and make sure those headers are included.
>> (it will warn otherwise with W=1).
>

Sure.

> and also split the patch in two.
>

Alright.

-- 
Regards,
Nikita Kiryanov


More information about the U-Boot mailing list