[U-Boot] [PATCH] blackfin: rename blackfin i2c driver to adi
Heiko Schocher
hs at denx.de
Fri Oct 31 09:06:48 CET 2014
Hello Scott Jiang,
Am 31.10.2014 08:12, schrieb Scott Jiang:
> Hi Heiko,
>
>
>>> static int wait_for_completion(struct i2c_msg *msg)
>>> {
>>> - uint16_t int_stat;
>>> + u16 int_stat, ctl;
>>
>>
>> This change is not related to the subject of the patch,
>> please split this into seperate patches ...
>>
>>> ulong timebase = get_timer(0);
>>>
>>> do {
>>> - int_stat = twi->int_stat;
>>> + int_stat = readw(&twi->int_stat);
>>
>>
>> Here too... please fix globally.
>>
>
> This patch is to modify blackfin specific string or api to generic.
> So I use standard io api readl/writel here. I'm not sure what you
> mean.
The use of the generic i/o accessors would be a seperate patch...
subject something like "blackfin i2c: use generic io accessors"
and put the rename specific changes into
"blackfin: rename blackfin i2c driver to adi"
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
More information about the U-Boot
mailing list