[U-Boot] [PATCH v3 1/2] arch: Make board selection choices optional

Masahiro Yamada yamada.masahiro at socionext.com
Sat Aug 1 09:46:25 CEST 2015


Hi Alexey,


2015-07-30 2:32 GMT+09:00 Alexey Brodkin <Alexey.Brodkin at synopsys.com>:
> Hi Joe, Masahiro-san,
>
> On Wed, 2015-07-29 at 20:25 +0300, Alexey Brodkin wrote:
>> Hi Joe,
>>
>> On Wed, 2015-05-13 at 10:11 +0900, Masahiro Yamada wrote:
>> > Hi Joe,
>> >
>> > 2015-05-13 7:12 GMT+09:00 Tom Rini <trini at konsulko.com>:
>> >
>> > > diff --git a/arch/arc/Kconfig b/arch/arc/Kconfig
>> > > index c044ad4..85fddd2 100644
>> > > --- a/arch/arc/Kconfig
>> > > +++ b/arch/arc/Kconfig
>> > > @@ -132,6 +132,7 @@ config ARC_CACHE_LINE_SHIFT
>> > >
>> > >  choice
>> > >         prompt "Target select"
>> > > +       optional
>> > >
>> > >  config TARGET_DUMMY
>> > >         bool "Dummy target"
>> >
>> >
>> > You do not need to add "optional" to the ARC board select
>> > because Alexey intentionally added TARGET_DUMMY
>> > to the top of the board select list.
>> >
>> > This is another solution to not lose any CONFIG_BOARD_
>> > by savedefconfig although I personally prefer this idea very much.
>
> It looks like I'm not the only one suffering from that change.
> For UniPhier that issue was resolved by Masahiro with replacement of
> "optional" with explicit default option.
>
> And probably that's the way we'll need to go for all other affected
> Kconfigs.
>
> Still all proposals are more than welcome.
>


Alexey, you are not alone.

I am also opposed to "optional"  in SoC/board select menu.

Maybe, we should choose a reasonable default in each select menu?
(or simply choose the first choice in the menu?)

I posted two patches:
http://patchwork.ozlabs.org/patch/502793/
http://patchwork.ozlabs.org/patch/502794/

I hope these two are not bad choice.



-- 
Best Regards
Masahiro Yamada


More information about the U-Boot mailing list