[U-Boot] [PATCH v3 07/16] common/cmd_ethsw: Add generic commands for Ethernet Switches

York Sun yorksun at freescale.com
Sat Aug 8 00:58:21 CEST 2015


On 08/07/2015 01:18 PM, Joe Hershberger wrote:
<snip>

>> +               }
>> +
>> +               /* if all our optional command's keywords perfectly match an
>> +                * optional pattern, then we can move to the next defined
>> +                * keywords in our command; remember the one that matched the
>> +                * greatest number of keywords
>> +                */
> 
> Improper comment format. Please make sure you always run your patches
> through checkpatch.pl. I recommend using patman!
> 

Joe,

Do you mean the multiple-line comment should start from the second line? I can
change it when I merge the patch.

Checkpatch/patman doesn't complain about this format.

York



More information about the U-Boot mailing list