[U-Boot] [PATCH v3 07/16] common/cmd_ethsw: Add generic commands for Ethernet Switches

[Joe Hershberger]

Hi York,

On Fri, Aug 7, 2015 at 5:58 PM, York Sun <yorksun at freescale.com> wrote:
> On 08/07/2015 01:18 PM, Joe Hershberger wrote:
> <snip>
>
>>> +               }
>>> +
>>> +               /* if all our optional command's keywords perfectly match an
>>> +                * optional pattern, then we can move to the next defined
>>> +                * keywords in our command; remember the one that matched the
>>> +                * greatest number of keywords
>>> +                */
>>
>> Improper comment format. Please make sure you always run your patches
>> through checkpatch.pl. I recommend using patman!
>>
>
> Joe,
>
> Do you mean the multiple-line comment should start from the second line? I can
> change it when I merge the patch.
>
> Checkpatch/patman doesn't complain about this format.

That is what I mean. I'm fairly certain that the format used here is
incorrect. Perhaps there is an exception set in checkpatch.pl for this
path or something.

U-Boot appears to defer to Linux Kernel style for this. It appears to
be an exception for "net" and "drivers/net" based on this:
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/CodingStyle

I'm not sure that u-boot is planning on following the same thing. I
honestly haven't gone looking for how much of this is in the U-Boot
source for net/.

As the network stack maintainer, I would prefer to avoid a network
stack difference from the rest of the codebase unless someone can
present a good reason to do this.

Thanks,
-Joe